chore: multi regional deployment pipeline #218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eedygreen
requested review from
P1sar,
mpetrun5,
tcar121293,
MakMuftic,
nmlinaric and
freddyli7
as code owners
eedygreen
changed the title
|
Go Test coverage is 65.7 %\ ✨ ✨ ✨ |
nmlinaric
approved these changes
Sep 25, 2023
P1sar
suggested changes
Sep 25, 2023
| name: sygma_deploy_devnet_to_regions | ||
|
|
||
| on: | ||
| workflow_dispatch: |
There was a problem hiding this comment.
should not it be on push, the same it was before?
There was a problem hiding this comment.
workflow dispatch does not need push commit. If we are going to deploy manually, then the commit is not manual.
| @@ -54,7 +54,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| relayer_id: [0, 1, 2, 3, 4] | |||
There was a problem hiding this comment.
I do not like that we are basically having copy of this file just to deploy to another region. Might we use if statements with matrix values? like if matrix.relayer_id.3 deploy to this region, etc.
Or for example we can use include statement of GA that allwos to add additional arguments to particular matrix elements. And we can use it to specify region per relayer_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deploy Relayers to other regions with an option to choose which region to deploy. Simply enter the AWS region name to deploy to that region.
Related Issue Or Context
Multi region deployment
Related #193